Messages in this thread | | | From | Grant Likely <> | Subject | Re: [PATCH v3] gpio: Add device driver for GRGPIO cores and support custom accessors with gpio-generic | Date | Sat, 02 Mar 2013 20:13:02 +0000 |
| |
On Fri, 1 Mar 2013 01:24:01 +0100, Linus Walleij <linus.walleij@linaro.org> wrote: > On Tue, Feb 12, 2013 at 8:24 AM, Andreas Larsson <andreas@gaisler.com> wrote: > > > This driver supports GRGPIO gpio cores available in the GRLIB VHDL IP > > core library from Aeroflex Gaisler. > > > > This also adds support to gpio-generic for using custom accessor > > functions. The grgpio driver uses this to use ioread32be and iowrite32be > > for big endian register accesses. > > > > Signed-off-by: Andreas Larsson <andreas@gaisler.com> > > Can you split this in two patches: one that adds the custom accessors > and one that adds the driver?
Yes please, and as commented on in the other thread you can go ahead and add the BE accessors to gpio-generic.c. I would like to optimize things in gpiolib to make a lot of gpio-generic.c unnecessary, but that is only an idea at this point.
g.
| |