lkml.org 
[lkml]   [2013]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] gpio: Add device driver for GRGPIO cores and support custom accessors with gpio-generic
On 2013-02-13 08:05, Anton Vorontsov wrote:
> On Tue, Feb 12, 2013 at 08:24:33AM +0100, Andreas Larsson wrote:
>> + res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
>> + regs = devm_request_and_ioremap(&ofdev->dev, res);
>
> Just wonder, is it safe to pass null res to devm_request_and_ioremap()?

Yes, and it is the preferred sequence of calls according to the
documentation of devm_request_and_ioremap.


>> + label = kstrdup(np->full_name, GFP_KERNEL);
>> + if (label)
>> + gc->label = label;
>
> Do we need to free label? If not, having a comment would be awesome. :)
> And should we print a warning for !label case?

Yes, it needs to be freed, thanks! The !label case is kind of OK as the
gpio system assigns some other label if it is NULL, but I'll require it
instead to make things easier.


>> +static int grgpio_remove(struct platform_device *ofdev)
>> +{
>> + dev_set_drvdata(&ofdev->dev, NULL);
>
> Is this really needed?

I guess not.


Thanks for the feedback! I take care of the other comments as well.

Cheers,
Andreas Larsson



\
 
 \ /
  Last update: 2013-02-13 16:01    [W:0.313 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site