lkml.org 
[lkml]   [2013]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] kconfig: print each first level disjunction block from a new line
From
Date
This patch improves readability of complicated expressions.

before:
Selected by: A && AA && AAA || B && BB && (BBB || BBBB) || C && CC && CCC

after:
Selected by: A && AA && AAA
|| B && BB && (BBB || BBBB)
|| C && CC && CCC

Modules' config options usually comes first in these blocks.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org
---
scripts/kconfig/expr.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/scripts/kconfig/expr.c b/scripts/kconfig/expr.c
index d662652..e47eb28 100644
--- a/scripts/kconfig/expr.c
+++ b/scripts/kconfig/expr.c
@@ -1087,9 +1087,15 @@ void expr_print(struct expr *e, void (*fn)(void *, struct symbol *, const char *
fn(data, e->right.sym, e->right.sym->name);
break;
case E_OR:
- expr_print(e->left.expr, fn, data, E_OR);
- fn(data, NULL, " || ");
- expr_print(e->right.expr, fn, data, E_OR);
+ if (prevtoken == E_NONE) {
+ expr_print(e->left.expr, fn, data, E_NONE);
+ fn(data, NULL, "\n|| ");
+ expr_print(e->right.expr, fn, data, E_NONE);
+ } else {
+ expr_print(e->left.expr, fn, data, E_OR);
+ fn(data, NULL, " || ");
+ expr_print(e->right.expr, fn, data, E_OR);
+ }
break;
case E_AND:
expr_print(e->left.expr, fn, data, E_AND);


\
 
 \ /
  Last update: 2013-03-21 10:01    [W:0.038 / U:1.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site