Messages in this thread | | | Date | Thu, 21 Mar 2013 16:08:45 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH] DMA: OF: Check properties value before running be32_to_cpup() on it |
| |
On Thu, Mar 21, 2013 at 03:48:50PM +0530, Viresh Kumar wrote: > On 21 March 2013 15:16, Vinod Koul <vinod.koul@intel.com> wrote: > > On Fri, Mar 15, 2013 at 02:18:20PM +0530, Viresh Kumar wrote: > >> In of_dma_controller_register() routine we are calling of_get_property() as an > >> parameter to be32_to_cpup(). In case the property doesn't exist we will get a > >> crash. > >> > >> This patch changes this code to check if we got a valid property first and then > >> runs be32_to_cpup() on it. > >> > >> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > >> --- > >> > >> My mails are broken, i have pushed this patch here: > > I noticed you used git send-email. Usually it will send patch properly > > independent of whatever MUA you use. > > Probably not!! Its the famous (Infamous) Microsoft exchange server working in > background and it breaks mails without treating mails coming from git send-email > specially :) I have seen usually receiving patches is a problem, not sending. at least at my work place till now my sent patches have not been broken but what I receive has thus forcing me to use non exchange accounts for receiving email but somehow situation is better for receiving too :) -- ~Vinod > > > So I have the patch and its applied now :) > > I have seen this kind of discrimination on breaking patches based on the size of > patch. If its very small (like this one), you may get a unbroken patch > but if the size > is a bit large then nobody can save you :)
> > -- > viresh
| |