Messages in this thread | | | From | Peter Korsgaard <> | Subject | Re: [PATCH v2 3/3] ARM: davinci: da850: add EHRPWM & ECAP DT node | Date | Wed, 20 Mar 2013 13:47:59 +0100 |
| |
>>>>> "Sekhar" == Sekhar Nori <nsekhar@ti.com> writes:
Sekhar> On 3/20/2013 12:11 PM, Philip Avinash wrote: >> Add da850 EHRPWM & ECAP DT node. >> Also adds OF_DEV_AUXDATA for EHRPWM & ECAP driver to use EHRPWM & ECAP >> clock. >> >> Signed-off-by: Philip Avinash <avinashphilip@ti.com> >> --- >> Changes since v1: >> - Reusing ti,am33xx<ecap/ehrpwm> as compatible field as both IP's are >> same with am33xx platform and da850 has no platform specific >> dependency.
Sekhar> Which is fine, but I think the binding documentation still needs to be Sekhar> updated to document the ti,da850-ehrpwm binding. Looping Peter (it is Sekhar> always a good idea to CC folks who reviewed your patch last time Sekhar> around). Also, please Cc the DT folks and devicetree-discuss list too Sekhar> for their opinion.
Yes, thanks for CC'ing me. I also think da850-* should be documented. See Documentation/devicetree/bindings/gpio/8xxx_gpio.txt for an similar (old) example.
-- Bye, Peter Korsgaard
| |