lkml.org 
[lkml]   [2013]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/3] arm: davinci: clock node support for ECAP & EHRPWM
On 3/20/2013 12:11 PM, Philip Avinash wrote:
> Add clock node support for ECAP and EHRPWM modules.
> Also adds TBCLK for EHRWPM TBCLK to comply with pwm-tiehrpwm
> driver.
>
> Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> ---
> Changes Since v1:
> - TBCLK make it as actual clock with enable/disable feature.
>
> :100644 100644 0c4a26d... dbed75c... M arch/arm/mach-davinci/da850.c
> :100644 100644 de439b7... be77ce2... M arch/arm/mach-davinci/include/mach/da8xx.h
> arch/arm/mach-davinci/da850.c | 46 ++++++++++++++++++++++++++++
> arch/arm/mach-davinci/include/mach/da8xx.h | 1 +
> 2 files changed, 47 insertions(+)
>
> diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
> index 0c4a26d..dbed75c 100644
> --- a/arch/arm/mach-davinci/da850.c
> +++ b/arch/arm/mach-davinci/da850.c
> @@ -383,6 +383,49 @@ static struct clk dsp_clk = {
> .flags = PSC_LRST | PSC_FORCE,
> };
>
> +static struct clk ehrpwm_clk = {
> + .name = "ehrpwm",
> + .parent = &pll0_sysclk2,
> + .lpsc = DA8XX_LPSC1_PWM,
> + .gpsc = 1,
> + .flags = DA850_CLK_ASYNC3,
> +};
> +
> +#define DA8XX_EHRPWM_TBCLKSYNC BIT(12)
> +
> +void tblck_enable(struct clk *clk)

This should be static. Also, since tbclk is associated with ehrpwm,
please call the function ehrpwm_tbclk_enable().

> +{
> + u32 val;
> +
> + val = readl(DA8XX_SYSCFG0_VIRT(DA8XX_CFGCHIP1_REG));
> + val |= DA8XX_EHRPWM_TBCLKSYNC;
> + writel(val, DA8XX_SYSCFG0_VIRT(DA8XX_CFGCHIP1_REG));
> +}
> +
> +void tblck_disable(struct clk *clk)

Same comment as above applies.

Thanks,
Sekhar


\
 
 \ /
  Last update: 2013-03-20 13:01    [W:0.123 / U:1.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site