lkml.org 
[lkml]   [2013]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] i2o/i2o_config: Validate message size
Date
Message size was already validated against inbound_frame_size, but that does
not guarantee that it is small enough for the buffer used to store a copy of it
on the stack.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
I am also not sure if the previous validation can be trusted, since the size
is read again from user space after the initial validation.

drivers/message/i2o/i2o_config.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/message/i2o/i2o_config.c b/drivers/message/i2o/i2o_config.c
index 5451bef..aabaafc 100644
--- a/drivers/message/i2o/i2o_config.c
+++ b/drivers/message/i2o/i2o_config.c
@@ -922,6 +922,10 @@ static int i2o_cfg_passthru(unsigned long arg)
}
size = size >> 16;
size *= 4;
+ if (size > sizeof(rmsg)) {
+ rcode = -EFAULT;
+ goto sg_list_cleanup;
+ }
/* Copy in the user's I2O command */
if (copy_from_user(rmsg, user_msg, size)) {
rcode = -EFAULT;
--
1.7.9.7


\
 
 \ /
  Last update: 2013-03-02 17:41    [W:0.034 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site