Messages in this thread | | | Date | Sat, 2 Mar 2013 15:08:25 +0800 | Subject | Re: [RFC PATCH 0/2] ipc: do not hold ipc lock more than necessary | From | Michel Lespinasse <> |
| |
On Sat, Mar 2, 2013 at 12:43 PM, Emmanuel Benisty <benisty.e@gmail.com> wrote: > Hi, > > On Sat, Mar 2, 2013 at 7:16 AM, Davidlohr Bueso <davidlohr.bueso@hp.com> wrote: >> The following set of not-thoroughly-tested patches are based on the >> discussion of holding the ipc lock unnecessarily, such as for permissions >> and security checks: >> >> https://lkml.org/lkml/2013/2/28/540 >> >> Patch 0/1: Introduces new functions, analogous to ipc_lock and ipc_lock_check >> in the ipc utility code, allowing to obtain the ipc object without holding the lock. >> >> Patch 0/2: Use the new functions and only acquire the ipc lock when needed. > > Not sure how much a work in progress this is but my machine dies > immediately when I start chromium, crappy mobile phone picture here: > http://i.imgur.com/S0hfPz3.jpg
We are missing the top of the trace there, so it's hard to be sure - however, this could well be caused by the if (!out) check (instead of if (IS_ERR(out)) that I noticed in patch 1/2.
-- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.
| |