Messages in this thread Patch in this message | | | From | Lai Jiangshan <> | Subject | [PATCH 21/21] workqueue: avoid false negative in assert_manager_or_pool_lock() | Date | Wed, 20 Mar 2013 03:28:21 +0800 |
| |
If lockdep complains something for other subsystem, lockdep_is_held() can be false negative. so we need to also test debug_locks before do assert.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> --- kernel/workqueue.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index ce8fd7b..13d4d46 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -304,7 +304,8 @@ static void copy_workqueue_attrs(struct workqueue_attrs *to, #ifdef CONFIG_LOCKDEP #define assert_manager_or_pool_lock(pool) \ - WARN_ONCE(!lockdep_is_held(&(pool)->manager_mutex) && \ + WARN_ONCE(debug_locks && \ + !lockdep_is_held(&(pool)->manager_mutex) && \ !lockdep_is_held(&(pool)->lock), \ "pool->manager_mutex or ->lock should be held") #else -- 1.7.7.6
| |