Messages in this thread Patch in this message | | | From | Lai Jiangshan <> | Subject | [PATCH 04/21] workqueue: swap the two branches in pwq_adjust_max_active() to get better readability | Date | Wed, 20 Mar 2013 03:28:04 +0800 |
| |
"if (!freezable || !(pwq->pool->flags & POOL_FREEZING))" is hard to read.
Swap the two branches. it becomes "if (freezable && (pwq->pool->flags & POOL_FREEZING))", it is better.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> --- kernel/workqueue.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index e1b31fc..8c882ae 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -3592,14 +3592,14 @@ static void pwq_adjust_max_active(struct pool_workqueue *pwq) spin_lock(&pwq->pool->lock); - if (!freezable || !(pwq->pool->flags & POOL_FREEZING)) { + if (freezable && (pwq->pool->flags & POOL_FREEZING)) { + pwq->max_active = 0; + } else { pwq->max_active = wq->saved_max_active; while (!list_empty(&pwq->delayed_works) && pwq->nr_active < pwq->max_active) pwq_activate_first_delayed(pwq); - } else { - pwq->max_active = 0; } spin_unlock(&pwq->pool->lock); -- 1.7.7.6
| |