Messages in this thread | | | From | <> | Subject | [RFC PATCHv2 0/1] usb: f_rndis: Avoid to use ERROR macro if cdev can be null | Date | Tue, 19 Mar 2013 12:11:42 +0100 |
| |
Hi,
This is patch version 2. Besides review I hope to get some feed-back on what the preferred solution is.
Background:
When going through our patches to be mainlined I stumbled on this one which we have fixed in many different ways internally.
The problem is a NULL pointer dereference that can be triggered by disconnecting the USB cable at a specific time.
Before submitting the final patch I would like to hear which solution you'd prefer. As I see it there are four different ways to fix the problem:
1) Remove the ERROR() call completely. 2) Add an if-statement on cdev in rndis_response_complete() and use pr_err() or ERROR(). 3) Globally update the ERROR() macro to handle the case where cdev is null. 4) Use the attached patch (RFC PATCHv2 1/1) where ERROR() is simply replaced with pr_err().
Thanks!
-Oskar
Truls Bengtsson (1): usb: f_rndis: Avoid to use ERROR macro if cdev can be null
drivers/usb/gadget/f_rndis.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
-- 1.7.8.6
| |