lkml.org 
[lkml]   [2013]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/12] USB: ehci-omap: Try to get PHY even if not in PHY mode
On Thu, 14 Mar 2013, Felipe Balbi wrote:

> > > if (IS_ERR(phy) || !phy) {
> > > + /* Don't bail out if PHY is not absolutely necessary */
> > > + if (pdata->port_mode[i] != OMAP_EHCI_PORT_MODE_PHY)
> > > + continue;
> > > +
> > > ret = IS_ERR(phy) ? PTR_ERR(phy) : -ENODEV;
> > > dev_err(dev, "Can't get PHY device for port %d: %d\n",
> > > i, ret);
> >
> > Felipe, this is a strange interface. Why do we sometimes get an
> > error-pointer and sometimes get just NULL? Why not always an
> > error-pointer?
>
> looks like we get NULL when PHY layer is disabled. Sounds like an
> oversight to me. Do you want to send a patch, or do I cook one and put
> yourself as Reported-by ?

You're more familiar with that code. "Reported-by" is good enough for
me. :-)

Alan Stern



\
 
 \ /
  Last update: 2013-03-14 16:43    [W:0.046 / U:1.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site