Messages in this thread | | | Date | Thu, 14 Mar 2013 16:08:32 +0200 | From | Felipe Balbi <> | Subject | Re: [PATCH 11/12] USB: ehci-omap: Try to get PHY even if not in PHY mode |
| |
On Tue, Mar 12, 2013 at 11:57:56AM -0400, Alan Stern wrote: > On Tue, 12 Mar 2013, Roger Quadros wrote: > > > Even when not in PHY mode, the USB device on the port (e.g. HUB) > > might need resources like RESET which can be modelled as a PHY > > device. So try to get the PHY device in any case. > > > > Signed-off-by: Roger Quadros <rogerq@ti.com> > > CC: Alan Stern <stern@rowland.harvard.edu> > > Acked-by: Alan Stern <stern@rowland.harvard.edu> > > > /* get the PHY device */ > > if (dev->of_node) > > phy = devm_usb_get_phy_by_phandle(dev, "phys", i); > > else > > phy = devm_usb_get_phy_dev(dev, i); > > if (IS_ERR(phy) || !phy) { > > + /* Don't bail out if PHY is not absolutely necessary */ > > + if (pdata->port_mode[i] != OMAP_EHCI_PORT_MODE_PHY) > > + continue; > > + > > ret = IS_ERR(phy) ? PTR_ERR(phy) : -ENODEV; > > dev_err(dev, "Can't get PHY device for port %d: %d\n", > > i, ret); > > Felipe, this is a strange interface. Why do we sometimes get an > error-pointer and sometimes get just NULL? Why not always an > error-pointer?
looks like we get NULL when PHY layer is disabled. Sounds like an oversight to me. Do you want to send a patch, or do I cook one and put yourself as Reported-by ?
-- balbi [unhandled content-type:application/pgp-signature] | |