lkml.org 
[lkml]   [2013]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] x84: reenable DEBUG_TLBFLUSH for X86_32
From
Date
CONFIG_INVLPG got removed in commit
094ab1db7cb7833cd4c820acd868fc26acf3f08e ("x86, 386 removal: Remove
CONFIG_INVLPG"). That commit left one instance of CONFIG_INVLPG
untouched, effectively disabling DEBUG_TLBFLUSH for X86_32. Since all
currently supported X86 CPU's should now be able to support that option,
just drop the entire sub-dependency.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Untested! This needs testing by the subsection of people running
DEBUG_TLBFLUSH on X86_32. I'm not in that subsection.

1) I actually wonder whether this check was needed in the first place.
It seems that the code depending on CONFIG_DEBUG_TLBFLUSH in
arch/x86/mm/tlb.c was actually safe to be called on any X86 CPU, since
it used to test for cpu_has_invlpg. But none of that matters anymore.

arch/x86/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index b322f12..16f7383 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -131,7 +131,7 @@ config DOUBLEFAULT

config DEBUG_TLBFLUSH
bool "Set upper limit of TLB entries to flush one-by-one"
- depends on DEBUG_KERNEL && (X86_64 || X86_INVLPG)
+ depends on DEBUG_KERNEL
---help---

X86-only for now.
--
1.7.11.7


\
 
 \ /
  Last update: 2013-03-14 13:21    [W:0.035 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site