Messages in this thread Patch in this message | | | From | Stephen Boyd <> | Subject | [PATCH] checkpatch: Complain about more executable files | Date | Wed, 13 Mar 2013 22:52:19 -0700 |
| |
We don't want executable permissions set on files such as devicetree syntax files, text files, defconfig files, or binary hex files.
Cc: Andy Whitcroft <apw@canonical.com> Cc: Joe Perches <joe@perches.com> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b28cc38..591867e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1576,7 +1576,7 @@ sub process { # Check for incorrect file permissions if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) { my $permhere = $here . "FILE: $realfile\n"; - if ($realfile =~ /(Makefile|Kconfig|\.c|\.h|\.S|\.tmpl)$/) { + if ($realfile =~ /(Makefile|Kconfig|\.c|\.h|\.S|\.tmpl|\.dts|\.dtsi|defconfig|\.txt|\.hex|\.HEX|\.ihex)$/) { ERROR("EXECUTE_PERMISSIONS", "do not set execute permissions for source files\n" . $permhere); } -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
| |