Messages in this thread | | | Date | Tue, 12 Mar 2013 09:04:01 -0700 | Subject | Re: [PATCH -tip ] [BUGFIX] kprobes: Move hash_64() into .text.kprobe section | From | Linus Torvalds <> |
| |
On Mon, Mar 11, 2013 at 7:22 AM, Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote: > Beacuse hash_64() is called from the get_kprobe() inside > int3 handler, kernel causes int3 recursion and crashes if > kprobes user puts a probe on it. > > Usually hash_64() is inlined into caller function, but in > some cases, it has instances by gcc's interprocedural > constant propagation. > > This patch adds __kprobes tag on the hash_64()
NAK. Don't do this. Just force inlining. There's absolutely no way we want to start adding __kprobe to random helper functions like this.
This isn't even about where "__kprobes" exists and whether we want to include the header file. This is about the fact that hash64 has absolutely *nothing* to do with kprobes, and we simply shouldn't do crap like this regardless of whether we need a new #include or not.
Linus
| |