lkml.org 
[lkml]   [2013]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip ] [BUGFIX] kprobes: Move hash_64() into .text.kprobe section

* Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:

> @@ -31,7 +32,7 @@
> #error Wordsize not 32 or 64
> #endif
>
> -static inline u64 hash_64(u64 val, unsigned int bits)
> +static __kprobes inline u64 hash_64(u64 val, unsigned int bits)
> {
> u64 hash = val;

We should also, really, really fix the '__kprobes' misnomer and switch to
the '__noprobe' pattern or so. The naming does not make it obvious at all
that what we do here is to turn _off_ kprobing of select functions...

The only complication is that __kprobes is now present in 600+ places,
which will create merge conflicts. If you remind me during the next merge
window I can generate the rename on the spot and send it to Linus without
anyone having to carry the patch for too long.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-03-12 10:01    [W:0.215 / U:1.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site