Messages in this thread | | | Date | Tue, 12 Mar 2013 09:07:46 +0000 | From | Chris Wilson <> | Subject | Re: [PATCH v3] drm/i915: bounds check execbuffer relocation count |
| |
On Mon, Mar 11, 2013 at 05:31:45PM -0700, Kees Cook wrote: > It is possible to wrap the counter used to allocate the buffer for > relocation copies. This could lead to heap writing overflows. > > CVE-2013-0913 > > v3: collapse test, improve comment > v2: move check into validate_exec_list > > Signed-off-by: Kees Cook <keescook@chromium.org> > Reported-by: Pinkie Pie > Cc: stable@vger.kernel.org
Looks good to me. The only bikeshed that remains is whether we should just collapse the two variables into one, but the current 'max - count' is more idiomatic and so preferrable. Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
-- Chris Wilson, Intel Open Source Technology Centre
| |