Messages in this thread | | | Date | Tue, 12 Mar 2013 00:44:47 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 4/4] drivers: android: binder: Fix compiler warning |
| |
On Mon, Mar 11, 2013 at 08:31:55PM +0100, Mirsal Ennaime wrote: > Fix an instance of -Wdeclaration-after-statement >
That's a compiler warning you introduced yourself on the previous patch. Obviously, we're not going to accept the original patch. :P
> Signed-off-by: Mirsal Ennaime <mirsal@mirsal.fr> > --- > drivers/staging/android/binder.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c > index 18a83e2..c833b53 100644 > --- a/drivers/staging/android/binder.c > +++ b/drivers/staging/android/binder.c > @@ -3001,11 +3001,12 @@ static void binder_deferred_release(struct binder_proc *proc) > page_count = 0; > if (proc->pages) { > int i; > + void *page_addr;
Put a blank line after the variable declaration section. Really the "int i" should go at the start of the function and the page_addr should go inside the for loop.
regards, dan carpenter
| |