lkml.org 
[lkml]   [2013]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 3/3] drivers: android: binder: Remove excessive indentation
    Date
    Remove one level of indentation from the binder proc page release code
    by using slightly different control semantics.

    This is a cosmetic patch which removes checkpatch "80-columns" warnings

    Signed-off-by: Mirsal Ennaime <mirsal@mirsal.fr>
    ---
    drivers/staging/android/binder.c | 25 ++++++++++++++-----------
    1 file changed, 14 insertions(+), 11 deletions(-)

    diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
    index 4652cd8..db214ce 100644
    --- a/drivers/staging/android/binder.c
    +++ b/drivers/staging/android/binder.c
    @@ -3001,17 +3001,20 @@ static void binder_deferred_release(struct binder_proc *proc)
    int i;

    for (i = 0; i < proc->buffer_size / PAGE_SIZE; i++) {
    - if (proc->pages[i]) {
    - void *page_addr = proc->buffer + i * PAGE_SIZE;
    - binder_debug(BINDER_DEBUG_BUFFER_ALLOC,
    - "binder_release: %d: page %d at %p not freed\n",
    - proc->pid, i,
    - page_addr);
    - unmap_kernel_range((unsigned long)page_addr,
    - PAGE_SIZE);
    - __free_page(proc->pages[i]);
    - page_count++;
    - }
    + void *page_addr;
    +
    + if (!proc->pages[i])
    + continue;
    +
    + page_addr = proc->buffer + i * PAGE_SIZE;
    + binder_debug(BINDER_DEBUG_BUFFER_ALLOC,
    + "binder_release: %d: page %d at %p not freed\n",
    + proc->pid, i,
    + page_addr);
    + unmap_kernel_range((unsigned long)page_addr,
    + PAGE_SIZE);
    + __free_page(proc->pages[i]);
    + page_count++;
    }

    kfree(proc->pages);
    --
    1.7.10.4


    \
     
     \ /
      Last update: 2013-03-12 01:01    [W:4.175 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site