lkml.org 
[lkml]   [2013]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subject[PATCH -next] staging: sync: fix return value check in sync_fence_alloc()
From
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

In case of error, the function anon_inode_getfile() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/staging/android/sync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
index b9bb974..bf66c19 100644
--- a/drivers/staging/android/sync.c
+++ b/drivers/staging/android/sync.c
@@ -261,7 +261,7 @@ static struct sync_fence *sync_fence_alloc(const char *name)

fence->file = anon_inode_getfile("sync_fence", &sync_fence_fops,
fence, 0);
- if (fence->file == NULL)
+ if (IS_ERR(fence->file))
goto err;

kref_init(&fence->kref);


\
 
 \ /
  Last update: 2013-03-11 15:21    [W:0.026 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site