lkml.org 
[lkml]   [2013]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 17/31] workqueue: implement attribute-based unbound worker_pool management
On Sun, Mar 10, 2013 at 05:58:21AM -0700, Tejun Heo wrote:
> > > + if (WARN_ON(pool->nr_workers != pool->nr_idle))
> > > + return;
> >
> > This can be false-negative. we should remove this WARN_ON().
>
> How would the test fail spuriously? Can you please elaborate?

I got it. It'll be short by one if there's an active manager.
Removed.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-03-10 20:21    [W:0.116 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site