Messages in this thread | | | Date | Thu, 7 Feb 2013 11:01:29 +0100 | Subject | Re: [PATCH 02/14] mfd: ab8500: provide a irq_set_type() function | From | Linus Walleij <> |
| |
On Thu, Feb 7, 2013 at 10:08 AM, Lee Jones <lee.jones@linaro.org> wrote:
> Great spot/idea. But then this won't work at all until I can write a fixup. > > Will you allow me to write a follow-up patch please?
For me a sequel is OK, especially given that this thing doesn't make things any worse than they are already, but actually checking supported types will not be trivial, because...
>> > +static int ab8500_irq_set_type(struct irq_data *data, unsigned int >> > type) >> > +{ >> > + return 0; >> > +}
This applies to *ALL* AB8500 IRQs, and some of them actually support rising/falling, apart from the GPIO ones, so it's not enough to just handle the GPIO IRQs here.
Yours, Linus Walleij
| |