lkml.org 
[lkml]   [2013]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/14] mfd: ab8500: provide a irq_set_type() function
    On 02/05/2013 12:48 PM, Linus Walleij wrote:
    > From: Lee Jones <lee.jones@linaro.org>
    >
    > In the AB8500 IRQ mask and unmask functions, we rely on testing for
    > IRQ_TYPE_EDGE_RISING and IRQ_TYPE_EDGE_FALLING interrupts to
    > physically mask and unmask the correct interrupt lines. In order
    > for us to do that, the trigger needs to be set in the associated
    > flags. However, unless a irq_set_type() function pointer is passed
    > when registering the IRQ chip, the IRQ subsystem will refuse to do
    > it. For that reason, we're providing one.

    > diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c

    > +static int ab8500_irq_set_type(struct irq_data *data, unsigned int type)
    > +{
    > + return 0;
    > +}

    I think patch 0 implied that only rising/falling edges can be detected,
    not levels? If so, should that function validate that the requested type
    can be supported?


    \
     
     \ /
      Last update: 2013-02-07 01:41    [W:4.044 / U:0.816 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site