Messages in this thread | | | Date | Tue, 5 Feb 2013 08:15:14 +0200 | From | Mika Westerberg <> | Subject | Re: [PATCH v3 05/10] spi/pxa2xx: break out the private DMA API usage into a separate file |
| |
On Mon, Feb 04, 2013 at 08:43:42PM +0100, Linus Walleij wrote: > On Tue, Jan 22, 2013 at 11:26 AM, Mika Westerberg > <mika.westerberg@linux.intel.com> wrote: > > > The PXA SPI driver uses PXA platform specific private DMA implementation > > which does not work on non-PXA platforms. In order to use this driver on > > other platforms we break out the private DMA implementation into a separate > > file that gets compiled only when CONFIG_SPI_PXA2XX_PXADMA is set. The DMA > > functions are stubbed out if there is no DMA implementation selected (i.e > > we are building on non-PXA platform). > > > > While we are there we can kill the dummy DMA bits in pxa2xx_spi.h as they > > are not needed anymore for CE4100. > > > > Once this is done we can add the generic DMA engine support to the driver > > that allows usage of any DMA controller that implements DMA engine API. > > > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > --- > > This patch was already acked by Linus W but since I changed this by > > breaking out the PXA private implementation into a separate file, I'm > > hoping to get new ack from him ;-) > > Sorry for the long delay. This is a nice and clean cut. > Acked-by: Linus Walleij <linus.walleij@linaro.org>
Thanks!
| |