Messages in this thread | | | Date | Mon, 4 Feb 2013 20:46:53 +0100 | Subject | Re: [PATCH v3 06/10] spi/pxa2xx: add support for DMA engine | From | Linus Walleij <> |
| |
On Tue, Jan 22, 2013 at 11:26 AM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
> To be able to use DMA with this driver on non-PXA platforms we implement > support for the generic DMA engine API. This lets user to use different DMA > engines with little or no modification to the driver. > > Request lines and channel numbers can be passed to the driver from the > platform specific data. > > The DMA engine implementation will be selected by default even on PXA > platform. User can select the legacy DMA API by enabling Kconfig option > CONFIG_SPI_PXA2XX_PXADMA. > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > --- > Linus W, there haven't been any comments from Vinod/Dan about the alignment > thing so I added a comment 'REVISIT: ..' so that we remember to change this > once it has been sorted out. I hope that is OK for you.
This is OK and the kernel sure looks better *after* this patch than *before* it, so it is a big step in the right direction in either case. Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |