Messages in this thread | | | From | "Liu, Chuansheng" <> | Subject | [Question]CLOCK_EVT_NOTIFY_BROADCAST_EXIT must be called with interrupts disabled? | Date | Tue, 26 Feb 2013 08:01:55 +0000 |
| |
Hi,
Just found some comments as below: In commit 0beefa208bb3a9e581a60125703 + /* + * The switch back from broadcast mode needs to be + * called with interrupts disabled. + */ + local_irq_disable(); + clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &cpu); + local_irq_enable();
But checked some place in kernel code, it likes below in intel_idle.c: local_irq_enable();
if (!(lapic_timer_reliable_states & (1 << (cstate)))) clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &cpu); Which enable the irq at first, then calling CLOCK_EVT_NOTIFY_BROADCAST_EXIT.
So not sure _BROAD_EXIT must be called with interrupts disabled? Thanks your comments in advance.
| |