lkml.org 
[lkml]   [2013]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[Question]CLOCK_EVT_NOTIFY_BROADCAST_EXIT must be called with interrupts disabled?
Date
Hi,

Just found some comments as below:
In commit 0beefa208bb3a9e581a60125703
+ /*
+ * The switch back from broadcast mode needs to be
+ * called with interrupts disabled.
+ */
+ local_irq_disable();
+ clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &cpu);
+ local_irq_enable();


But checked some place in kernel code, it likes below in intel_idle.c:
local_irq_enable();

if (!(lapic_timer_reliable_states & (1 << (cstate))))
clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &cpu);
Which enable the irq at first, then calling CLOCK_EVT_NOTIFY_BROADCAST_EXIT.

So not sure _BROAD_EXIT must be called with interrupts disabled? Thanks your comments in advance.




\
 
 \ /
  Last update: 2013-02-26 09:43    [W:0.037 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site