lkml.org 
[lkml]   [2013]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 2/6] mfd: Add ChromeOS EC implementation
On Wed, Feb 20, 2013 at 09:24:35AM -0800, Simon Glass wrote:
> This is the base EC implementation, which provides a high level
> interface to the EC for use by the rest of the kernel. The actual
> communcations is dealt with by a separate protocol driver which
> registers itself with this interface.
>
> Interrupts are passed on through a notifier.
>
> A simple message structure is used to pass messages to the
> protocol driver.
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Che-Liang Chiou <clchiou@chromium.org>
> Signed-off-by: Jonathan Kliegman <kliegs@chromium.org>
> Signed-off-by: Luigi Semenzato <semenzato@chromium.org>
> Signed-off-by: Olof Johansson <olofj@chromium.org>
> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>

...

>
> +config MFD_CROS_EC
> + bool "Support ChromeOS Embedded Controller"
> + help
> + If you say Y here you get support for the ChromeOS Embedded
> + Controller (EC) providing keyboard, battery and power services.
> + You also ned to enable the driver for the bus you are using. The
> + protocol for talking to the EC is defined by the bus driver.

Why can't it be a module?

> +
> +#ifndef __LINUX_MFD_CROS_EC_H
> +#define __LINUX_MFD_CROS_EC_H
> +
> +struct i2c_msg;

I do not believe this is needed here.

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2013-02-20 20:21    [W:0.117 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site