Messages in this thread | | | Date | Wed, 20 Feb 2013 10:21:35 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v5 6/6] Input: Add ChromeOS EC keyboard driver |
| |
On Wed, Feb 20, 2013 at 09:24:39AM -0800, Simon Glass wrote: > + > + code = keycodes[pos]; > + new_state = kb_state[col] & (1 << row); > + if (!!new_state != test_bit(code, idev->key)) { > + dev_dbg(ckdev->dev, > + "changed: [r%d c%d]: byte %02x\n", > + row, col, new_state); > + > + input_report_key(idev, code, new_state);
Incorrect indentation.
> + }
...
> +static int cros_ec_keyb_probe(struct platform_device *pdev) > +{ > + struct cros_ec_device *ec = dev_get_drvdata(pdev->dev.parent); > + struct device *dev = ec->dev; > + struct cros_ec_keyb *ckdev = NULL; > + struct input_dev *idev = NULL;
Why are we assigning these to NULL?
Otherwise
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
-- Dmitry
| |