lkml.org 
[lkml]   [2013]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/6] f2fs: optimize get node page readahead part
Date
From: Namjae Jeon <namjae.jeon@samsung.com>

We can remove the call to find_get_page to get a page from the cache
and check for up-to-date, instead we can make use of grab_cache_page
part itself to fetch the page from the cache.
So, removing the call and moving the PageUptodate at proper place, also
taken care of moving the lock_page condition in the page_hit part.

Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
---
fs/f2fs/node.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 33fa6d5..723185b 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -920,15 +920,12 @@ struct page *get_node_page_ra(struct page *parent, int start)
if (!nid)
return ERR_PTR(-ENOENT);

- page = find_get_page(mapping, nid);
- if (page && PageUptodate(page))
- goto page_hit;
- f2fs_put_page(page, 0);
-
repeat:
page = grab_cache_page(mapping, nid);
if (!page)
return ERR_PTR(-ENOMEM);
+ else if (PageUptodate(page))
+ goto page_hit;

err = read_node_page(page, READA);
if (err) {
@@ -946,8 +943,9 @@ repeat:
ra_node_page(sbi, nid);
}

-page_hit:
lock_page(page);
+
+page_hit:
if (PageError(page)) {
f2fs_put_page(page, 1);
return ERR_PTR(-EIO);
--
1.7.9.5


\
 
 \ /
  Last update: 2013-02-02 16:21    [W:2.160 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site