lkml.org 
[lkml]   [2013]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] drivers/gpio/*twl* need call irq_free_descs when leaving

since already call irq_alloc_descs before,
we need call irq_free_descs when quiting, or resource leak.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
drivers/gpio/gpio-twl4030.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/gpio/gpio-twl4030.c b/drivers/gpio/gpio-twl4030.c
index 4d330e3..26aef72 100644
--- a/drivers/gpio/gpio-twl4030.c
+++ b/drivers/gpio/gpio-twl4030.c
@@ -486,8 +486,10 @@ static int gpio_twl4030_probe(struct platform_device *pdev)
&irq_domain_simple_ops, NULL);

ret = twl4030_sih_setup(&pdev->dev, TWL4030_MODULE_GPIO, irq_base);
- if (ret < 0)
+ if (ret < 0) {
+ irq_free_descs(irq_base, TWL4030_GPIO_MAX);
return ret;
+ }

priv->irq_base = irq_base;

@@ -578,6 +580,7 @@ static int gpio_twl4030_remove(struct platform_device *pdev)

/* REVISIT no support yet for deregistering all the IRQs */
WARN_ON(1);
+ irq_free_descs(priv->irq_base, TWL4030_GPIO_MAX);
return -EIO;
}

--
1.7.7.6


\
 
 \ /
  Last update: 2013-02-16 09:01    [W:0.048 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site