lkml.org 
[lkml]   [2013]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: + futex-avoid-kernel-taint-caused-by-get_robust_list.patch added to -mm tree
Am Fri, 15 Feb 2013 14:26:52 -0800
schrieb akpm@linux-foundation.org:
> ------------------------------------------------------
> From: Paul Gortmaker <paul.gortmaker@windriver.com>
> Subject: futex: avoid kernel taint caused by get_robust_list
>
> Commit ec0c4274e33c0373e4 ("futex: Mark get_robust_list as
> deprecated") added these two WARN_ONCE calls.
>
> However, WARN_ONCE taints the kernel, and we shouldn't be allowing any
> user who wanders by to do this. For example, the system fuzzer
> "trinity" uses the tainted state as a metric for when to stop,
> assuming that it has caused significant wreckage (and indeed that
> tool is what actually led me to this change).
>
> The ability to deprecate this code has been called into question[1],
> but if that remains to be finalized, then making this change in the
> interim seems to make sense.

Do we really want to remove this system call in 2013?
Note, Documentation/feature-removal-schedule.txt is gone...

CRIU folks, I guess you still need the call?
Or have you found an alternative way to get the robost list?

As stated in [0], I'd simply revert commit ec0c4274 ("futex: Mark
get_robust_list as deprecated")

Thanks,
//richard

[0] http://permalink.gmane.org/gmane.linux.kernel.hardened.devel/506


\
 
 \ /
  Last update: 2013-02-16 00:22    [W:0.061 / U:1.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site