Messages in this thread | | | Date | Fri, 15 Feb 2013 17:02:57 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH EDAC 07/13] edac: add support for raw error reports |
| |
On Fri, Feb 15, 2013 at 01:49:29PM -0200, Mauro Carvalho Chehab wrote: > Sure, but calling kmalloc while handling a memory error doesn't seem > a very good idea, IMHO. So, better to either use an already allocated > space (or the stack).
Either that, or prealloc a buffer on EDAC initialization. You probably won't need more than one in 99% of the cases so if you keep it simple with a single static buffer for starters, that would probably be the cleanest solution.
> Yes, I know, but, on the other hand, there's the additional cost of > copying almost all data into the structure.
That's very easily paralelizable on out-of-order CPUs (I'd say, all of them which need to run EDAC, can do that :-)) so it wouldn't hurt.
Also, you could allocate the struct in the callers and work directly with its members before sending it down to edac_raw_mc_handle_error() - that would probably simplify the code a bit more.
> Ok, I'll keep this patch on my git. I'll likely fold it with the > previous one on the final patchset.
Yep.
Thanks.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |