Messages in this thread | | | Date | Fri, 15 Feb 2013 16:41:23 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH EDAC 07/13] edac: add support for raw error reports |
| |
On Fri, Feb 15, 2013 at 01:25:30PM -0200, Mauro Carvalho Chehab wrote: > Well, for sure using an structure will help to avoid missing a > parameter or exchanging its order. The stack usage won't reduce, > though, because the structure will keep using the stack.
If you allocate it on the stack of the caller, yes. If you kmalloc it, no.
In any case, passing a pointer to struct edac_raw_error_desc only will allow on x86_64 (and i386 AFAICT) to use only registers to pass callee function arguments. Which is always a win. You probably need to stare at compiler output to see what gcc actually does with -O2 optimizations.
> As I can't foresee the usage of this function call outside the core > and by the GHES driver, I'm not sure what would be the better.
Having an error descriptor is always better, even if it were only for clarity's and simplicity's sake.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |