Messages in this thread | | | From | Alexandre Courbot <> | Subject | [PATCH v2 0/4] gpiolib: some fixup patches | Date | Fri, 15 Feb 2013 14:46:13 +0900 |
| |
This short series is a fixup to patch 6/9 of my previous series ("gpiolib: use descriptors internally"), which mainly addresses issues raised by Linus W. in this patch and a few other minor ones caught while proof-reading gpiolib.
First patch is the most significant. It mostly avoids oopses when passing an invalid GPIO to some functions. Also gpio_get/set_value*() now return 0 when given an invalid GPIO number instead of oopsing. I tend to think that's an improvement, but if it's not please let me know.
Ideally these patches should be melded into the above-mentioned patch since they were intended to become a new revision, but I leave that decision to Grant's discretion.
This patchset has been tested on Tegra 2/Ventana with a GPIO backlight driver and the sysfs interface.
Changes from v1: - as suggested by Ryan Mallon, add a dedicated control flow for signaling invalid GPIOs to avoid meaningless error messages and ugly ternary operators - use pr_warn instead of pr_debug to signal invalid GPIOs - do descriptors validity check before acquiring any lock
Alexandre Courbot (4): gpiolib: check descriptors validity before use gpiolib: use const parameters when possible gpiolib: move comment to right function gpiolib: rename local offset variables to "hwgpio"
drivers/gpio/gpiolib.c | 213 +++++++++++++++++++++++++++---------------------- 1 file changed, 117 insertions(+), 96 deletions(-)
-- 1.8.1.3
| |