Messages in this thread | | | Date | Tue, 12 Feb 2013 21:27:59 +0530 | Subject | Re: [PATCH 3/6] dma: coh901318_lli: avoid unbalanced locking | From | Viresh Kumar <> |
| |
On 12 February 2013 16:28, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > I have not checked the code but there is a possibility that custom pool->lock > is not needed at all due to dma_pool contains it's own lock.
Your viewpoint is fine, but we wanted the reason behind this patch here. Please add appropriate stuff in only in logs.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/dma/coh901318_lli.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/coh901318_lli.c b/drivers/dma/coh901318_lli.c > index 3e96610..702112d 100644 > --- a/drivers/dma/coh901318_lli.c > +++ b/drivers/dma/coh901318_lli.c > @@ -61,7 +61,7 @@ coh901318_lli_alloc(struct coh901318_pool *pool, unsigned int len) > dma_addr_t phy; > > if (len == 0) > - goto err; > + return NULL; > > spin_lock(&pool->lock); > > -- > 1.7.10.4 >
| |