lkml.org 
[lkml]   [2013]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/6] dmaengine.h: remove redundant else keyword
From
On 12 February 2013 16:28, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> dmaengine_device_control returns -ENOSYS in case the dma driver doesn't have
> such functionality.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/linux/dmaengine.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index bfcdecb..b760b38 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -610,8 +610,7 @@ static inline int dmaengine_device_control(struct dma_chan *chan,
> {
> if (chan->device->device_control)
> return chan->device->device_control(chan, cmd, arg);
> - else
> - return -ENOSYS;
> + return -ENOSYS;

I don't know really which one to prefer here :)

Anyway, if you want this one, then get a blank line before your return code.


\
 
 \ /
  Last update: 2013-02-12 16:21    [W:0.995 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site