Messages in this thread | | | From | Tomasz Figa <> | Subject | Re: [PATCH v4] i2c: s3c2410: dont need CPU_FREQ transitions for exynos series | Date | Mon, 09 Dec 2013 17:09:19 +0100 |
| |
Hi Naveen,
On Tuesday 26 of November 2013 09:52:46 Naveen Krishna Chatradhi wrote: > For Exynos4 and Exynos5 SoCs from Samsung the i2c clock is based > on a fixed 66 MHz peripheral clock, and therefore is completely > independent of the cpu frequency. > Thus, registering for a CPU freq notifier is very wasteful. > > This patch modifes the code such that, i2c bus registers to > cpu_freq_transition only if CONFIG_CPU_FREQ_S3C24XX is enabled. > > This change should save a bunch of cpufreq transitions calls > which does not apply to exynos SoCs. > > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com> > Reviewed-by: Doug Anderson <dianders@chromium.org> > --- > Changes since v3: > As per discussion at https://patchwork.kernel.org/patch/3235091/ > Post f023f8dd59 commit we should be using > ARM_S3C24XX_CPUFREQ instead of CPU_FREQ_S3C24XX > > upstrea linux kernel and linuxsamsung already has the commit > f023f8dd59. Hence, rebasing the patch. > > drivers/i2c/busses/i2c-s3c2410.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Wolfram, are you okay with this patch?
Best regards, Tomasz
| |