Messages in this thread | | | Date | Mon, 25 Nov 2013 15:41:43 -0800 | Subject | Re: [PATCH v3] i2c: s3c2410: dont need CPU_FREQ transitions for exynos series | From | Doug Anderson <> |
| |
Naveen,
On Mon, Nov 18, 2013 at 10:18 PM, Naveen Krishna Chatradhi <ch.naveen@samsung.com> wrote: > For Exynos4 and Exynos5 SoCs from Samsung the i2c clock is based > on a fixed 66 MHz peripheral clock, and therefore is completely > independent of the cpu frequency. > Thus, registering for a CPU freq notifier is very wasteful. > > This patch modifes the code such that, i2c bus registers to > cpu_freq_transition only if CONFIG_CPU_FREQ_S3C24XX is enabled. > > This change should save a bunch of cpufreq transitions calls > which does not apply to exynos SoCs. > > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com> > Reviewed-by: Doug Anderson <dianders@chromium.org> > --- > Changes since v2: > None, Rebased on for-next of linux-i2c git repo. > > Changes since v1: > Use CONFIG_CPU_FREQ_S3C24XX instead of (CONFIG_CPU_FREQ & !CONFIG_EXYNOS) > As commented by Tomasz > > drivers/i2c/busses/i2c-s3c2410.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Can you please spin this with comments from <https://patchwork.kernel.org/patch/3235091/>? Thanks!
-Doug
| |