lkml.org 
[lkml]   [2013]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] xen/debugfs: Check debugfs initialization before using it
Date
Should check debugfs initialization with debugfs_initialized() before using it,
Because if it isn't initialized, the return value of fake debugfs_create_dir() etc
functions would be ERR_PTR(-ENODEV), checking with NULL will not work.

Signed-off-by: ethan.zhao <ethan.kernel@gmail.com>
---
arch/x86/xen/debugfs.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/arch/x86/xen/debugfs.c b/arch/x86/xen/debugfs.c
index c8377fb..85c0e0e 100644
--- a/arch/x86/xen/debugfs.c
+++ b/arch/x86/xen/debugfs.c
@@ -9,12 +9,18 @@ static struct dentry *d_xen_debug;

struct dentry * __init xen_init_debugfs(void)
{
+ if (!debugfs_initialized()) {
+ d_xen_debug = NULL;
+ goto nodebugfs;
+ }
+
if (!d_xen_debug) {
d_xen_debug = debugfs_create_dir("xen", NULL);

if (!d_xen_debug)
pr_warning("Could not create 'xen' debugfs directory\n");
}
+nodebugfs:

return d_xen_debug;
}
--
1.8.3.4 (Apple Git-47)


\
 
 \ /
  Last update: 2013-12-08 13:21    [W:0.045 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site