lkml.org 
[lkml]   [2013]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] mm/zswap.c: add BUG() for default case in zswap_writeback_entry()
    Recommend to add default case to avoid compiler's warning, although at
    present, the original implementation is still correct.

    The related warning (with allmodconfig for metag):

    CC mm/zswap.o
    mm/zswap.c: In function 'zswap_writeback_entry':
    mm/zswap.c:537: warning: 'ret' may be used uninitialized in this function


    Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
    ---
    mm/zswap.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/mm/zswap.c b/mm/zswap.c
    index 5a63f78..bfd1807 100644
    --- a/mm/zswap.c
    +++ b/mm/zswap.c
    @@ -585,6 +585,8 @@ static int zswap_writeback_entry(struct zbud_pool *pool, unsigned long handle)

    /* page is up to date */
    SetPageUptodate(page);
    + default:
    + BUG();
    }

    /* move it to the tail of the inactive list after end_writeback */
    --
    1.7.7.6

    \
     
     \ /
      Last update: 2013-12-09 04:21    [W:3.322 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site