Messages in this thread Patch in this message | | | Date | Mon, 09 Dec 2013 10:51:16 +0800 | From | Chen Gang <> | Subject | [PATCH] mm/zswap.c: add BUG() for default case in zswap_writeback_entry() |
| |
Recommend to add default case to avoid compiler's warning, although at present, the original implementation is still correct.
The related warning (with allmodconfig for metag):
CC mm/zswap.o mm/zswap.c: In function 'zswap_writeback_entry': mm/zswap.c:537: warning: 'ret' may be used uninitialized in this function
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> --- mm/zswap.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/mm/zswap.c b/mm/zswap.c index 5a63f78..bfd1807 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -585,6 +585,8 @@ static int zswap_writeback_entry(struct zbud_pool *pool, unsigned long handle) /* page is up to date */ SetPageUptodate(page); + default: + BUG(); } /* move it to the tail of the inactive list after end_writeback */ -- 1.7.7.6
| |