Messages in this thread | | | Date | Fri, 6 Dec 2013 09:29:31 -0800 | From | Guenter Roeck <> | Subject | Re: [net-next PATCH 3/6] macvtap: remove the dead branch |
| |
On Fri, Dec 06, 2013 at 11:46:02AM -0500, David Miller wrote: > From: Guenter Roeck <linux@roeck-us.net> > Date: Thu, 05 Dec 2013 22:08:20 -0800 > > > Assigning the function's return value to ret just to ignore it seems > > odd. > > > > Might make sense to change the function type to void. > > That's exactly what his very next patch does, undoubtedly the two > patches should be combined into one. > Yes, I think that would be a good idea.
Thanks, Guenter
| |