Messages in this thread | | | Date | Fri, 06 Dec 2013 11:46:02 -0500 (EST) | Subject | Re: [net-next PATCH 3/6] macvtap: remove the dead branch | From | David Miller <> |
| |
From: Guenter Roeck <linux@roeck-us.net> Date: Thu, 05 Dec 2013 22:08:20 -0800
> Assigning the function's return value to ret just to ignore it seems > odd. > > Might make sense to change the function type to void.
That's exactly what his very next patch does, undoubtedly the two patches should be combined into one.
| |