| Date | Sat, 7 Dec 2013 00:10:24 +0000 | From | Ben Hutchings <> | Subject | Re: [PATCH 3.8 003/152] cxgb3: Fix length calculation in write_ofld_wr() on 32-bit architectures |
| |
On Fri, Dec 06, 2013 at 03:08:47PM -0800, Kamal Mostafa wrote: > 3.8.13.14 -stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Ben Hutchings <ben@decadent.org.uk> > > [ Upstream commit 262e827fe745642589450ae241b7afd3912c3f25 ] > > The length calculation here is now invalid on 32-bit architectures, > since sk_buff::tail is a pointer and sk_buff::transport_header is > an integer offset: > > drivers/net/ethernet/chelsio/cxgb3/sge.c: In function 'write_ofld_wr': > drivers/net/ethernet/chelsio/cxgb3/sge.c:1603:9: warning: passing argument 4 of 'make_sgl' makes integer from pointer without a cast [enabled by default] > adap->pdev); > ^ > drivers/net/ethernet/chelsio/cxgb3/sge.c:964:28: note: expected 'unsigned int' but argument is of type 'sk_buff_data_t' > static inline unsigned int make_sgl(const struct sk_buff *skb, > ^ > > Use the appropriate skb accessor functions. > > Compile-tested only. > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk> > Fixes: 1a37e412a022 ('net: Use 16bits for *_headers fields of struct skbuff') [...]
This is only needed for 3.11+, though it should be harmless for older versions.
Ben.
-- Ben Hutchings Design a system any fool can use, and only a fool will want to use it.
|