lkml.org 
[lkml]   [2013]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.8 109/152] devpts: plug the memory leak in kill_sb
    Date
    3.8.13.14 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ilija Hadzic <ihadzic@research.bell-labs.com>

    commit 66da0e1f9034140ae2f571ef96e254a25083906c upstream.

    When devpts is unmounted, there may be a no-longer-used IDR tree hanging
    off the superblock we are about to kill. This needs to be cleaned up
    before destroying the SB.

    The leak is usually not a big deal because unmounting devpts is typically
    done when shutting down the whole machine. However, shutting down an LXC
    container instead of a physical machine exposes the problem (the garbage
    is detectable with kmemleak).

    Signed-off-by: Ilija Hadzic <ihadzic@research.bell-labs.com>
    Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    fs/devpts/inode.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c
    index 472e6be..1d24d57 100644
    --- a/fs/devpts/inode.c
    +++ b/fs/devpts/inode.c
    @@ -483,6 +483,7 @@ static void devpts_kill_sb(struct super_block *sb)
    {
    struct pts_fs_info *fsi = DEVPTS_SB(sb);

    + ida_destroy(&fsi->allocated_ptys);
    kfree(fsi);
    kill_litter_super(sb);
    }
    --
    1.8.3.2


    \
     
     \ /
      Last update: 2013-12-07 02:21    [W:3.079 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site