lkml.org 
[lkml]   [2013]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/4] introduce for_each_thread() to replace the buggy while_each_thread()
On Thu, 5 Dec 2013, Oleg Nesterov wrote:

> > Minor: should the definitions of thread_{head,node} be annotated with
> > __rcu for users of CONFIG_SPARSE_RCU_POINTER?
>
> Perhaps. And perhaps task_struct->tasks. And perhaps we should add
> rcu_read_lock_held() || lockdep_is_held(tasklist) || lockdep_is_held(siglock)
> into for_each_process/thead.
>
> But lets do this later. At least we should avoid the false positives.
>

Ok, thanks. I think anything we can do to catch these cases of
unprotected usage even with some debugging options like
CONFIG_SPARSE_RCU_POINTER and CONFIG_LOCKDEP will help given the number of
places you found that were doing it incorrectly already.


\
 
 \ /
  Last update: 2013-12-06 00:41    [W:0.245 / U:24.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site