lkml.org 
[lkml]   [2013]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 08/23] mm/memblock: Add memblock memory allocation apis
Hello,

On Thu, Dec 05, 2013 at 06:35:00PM +0200, Grygorii Strashko wrote:
> >> +#define memblock_virt_alloc_align(x, align) \
> >> + memblock_virt_alloc_try_nid(x, align, BOOTMEM_LOW_LIMIT, \
> >> + BOOTMEM_ALLOC_ACCESSIBLE, MAX_NUMNODES)
> >
> > Also, do we really need this align variant separate when the caller
> > can simply specify 0 for the default?
>
> Unfortunately Yes.
> We need it to keep compatibility with bootmem/nobootmem
> which don't handle 0 as default align value.

Hmm... why wouldn't just interpreting 0 to SMP_CACHE_BYTES in the
memblock_virt*() function work?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-12-05 18:01    [W:0.714 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site