Messages in this thread | | | Date | Thu, 5 Dec 2013 13:51:16 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH v2 08/23] mm/memblock: Add memblock memory allocation apis |
| |
Hey,
On Thu, Dec 05, 2013 at 06:48:21PM +0000, Strashko, Grygorii wrote: > +/* Fall back to all the existing bootmem APIs */ > +#define memblock_virt_alloc(x) \ > + __alloc_bootmem(x, SMP_CACHE_BYTES, BOOTMEM_LOW_LIMIT) > > which will be transformed to > +/* Fall back to all the existing bootmem APIs */ > +#define memblock_virt_alloc(x, align) \ > + __alloc_bootmem(x, align, BOOTMEM_LOW_LIMIT) > > and used as > > memblock_virt_alloc(size, 0); > > so, by default bootmem code will use 0 as default alignment and not SMP_CACHE_BYTES > and that is wrong.
Just translate it to SMP_CACHE_BYTES? Am I missing something here? You're defining a new API which wraps around two interfaces. Wrap them so that they show the same desired behavior?
-- tejun
| |