Messages in this thread Patch in this message | | | From | Stefan Weil <> | Subject | [PATCH] Documentation: Fix size parameter for snprintf (reported by cppcheck) | Date | Mon, 30 Dec 2013 12:35:43 +0100 |
| |
cppcheck reports this error:
Documentation/laptops/hpfall.c:33]: (error) Dangerous usage of 'devname' (strncpy doesn't always 0-terminate it)
The terminating '\0' is needed for the global char array unload_heads_path, so never write the last array entry (which is initially '\0').
Signed-off-by: Stefan Weil <sw@weilnetz.de> ---
This is only code in the documentation, nevertheless even there a correction might help other users.
Cheers and happy new year
Stefan Weil
Documentation/laptops/hpfall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/laptops/hpfall.c b/Documentation/laptops/hpfall.c index a4a8fc5..b85dbba 100644 --- a/Documentation/laptops/hpfall.c +++ b/Documentation/laptops/hpfall.c @@ -29,7 +29,7 @@ int set_unload_heads_path(char *device) return -EINVAL; strncpy(devname, device + 5, sizeof(devname)); - snprintf(unload_heads_path, sizeof(unload_heads_path), + snprintf(unload_heads_path, sizeof(unload_heads_path) - 1, "/sys/block/%s/device/unload_heads", devname); return 0; } -- 1.7.10.4
| |