Messages in this thread | | | From | Pali Rohár <> | Subject | Re: [PATCH v2] Bluetooth: Add hci_h4p driver | Date | Mon, 30 Dec 2013 15:31:25 +0100 |
| |
On Saturday 28 December 2013 02:21:23 Marcel Holtmann wrote: > Hi Pali, > > > I'm sending updated version of hci_h4p bluetooth driver. It > > is needed for Nokia N900 bluetooth hardware. This (v2) is > > older version of hci_h4p driver, but I tested it with > > v3.13-rc3 kernel on Nokia N900 and working without any > > problems. Previous (v1) version had some problems. So for > > future development please use this (v2) version of hci_h4p > > driver. > > please create a proper commit message explaining this driver. > Revision updates should go between the diffstat and the patch > itself. Use git format-patch and you see what I mean. >
Ok. First what I wanted was to have working driver with new kernel. I sent it so other people can look at code and fix what is needed... I think that correct commit message is not needed now.
> > diff --git a/drivers/bluetooth/Kconfig > > b/drivers/bluetooth/Kconfig index 11a6104..95155c3 100644 > > --- a/drivers/bluetooth/Kconfig > > +++ b/drivers/bluetooth/Kconfig > > @@ -242,4 +242,14 @@ config BT_WILINK > > > > Say Y here to compile support for Texas Instrument's > > WiLink7 driver into the kernel or say M to compile it as > > module. > > > > + > > +config BT_HCIH4P > > + tristate "HCI driver with H4 Nokia extensions" > > + depends on BT && ARCH_OMAP > > Since then we moved away from doing hci_* prefix of drivers > since that is misleading. See btusb.ko, btmrvl_sdio.ko etc. > > So this might be better named BT_NOK_H4P or BT_NOKIA_H4P and > the module named btnok_h4p.ko or btnokia_h4p.ko. > > I still never understood what “p” was for. >
I do not know too, I did not invent that name. I just copied kernel driver from nokia kernel and patched it to work with 3.12.
Maybe 'p' means plus (+) as H4+.
> Can we also make this just depend on some device tree > information and not on a specific architecture. I know that > this driver is pretty much OMAP specific, but if we want this > upstream, we should at least try to make it more generic. >
Sebastian, can you look at code how hard is to add DT support?
> > +MODULE_DESCRIPTION("Bluetooth h4 driver with nokia > > extensions"); +MODULE_LICENSE("GPL"); > > +MODULE_AUTHOR("Ville Tervo"); > > +MODULE_FIRMWARE(FW_NAME_TI1271_PRELE); > > +MODULE_FIRMWARE(FW_NAME_TI1271_LE); > > +MODULE_FIRMWARE(FW_NAME_TI1271); > > +MODULE_FIRMWARE(FW_NAME_BCM2048); > > +MODULE_FIRMWARE(FW_NAME_CSR); > > Do we actually have all these firmware files still available. > If not, then focus on the ones we have. >
Firmware files are available for download from nemo project:
https://api.merproject.org/public/source/nemo:devel:hw:ti:omap3:n900/bcm-bt-firmware/bcm-bt-firmware-0.21rc3.tar.bz2
https://api.merproject.org/public/source/nemo:devel:hw:ti:omap3:n950-n9/ti-wl1273-bt-firmware/bt-firmware-ti1273_0.23+0m6.tar.gz
-- Pali Rohár pali.rohar@gmail.com
[unhandled content-type:application/pgp-signature] | |